Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] H5: check ascii in file to utf8 memory #817

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gicmo
Copy link
Member

@gicmo gicmo commented May 1, 2020

Check that ASCII encoded data in the file can be read into memory.

@gicmo gicmo force-pushed the ascii_utf8_strings branch from ba3b69e to 97b2198 Compare November 21, 2020 14:17
@gicmo gicmo marked this pull request as draft November 21, 2020 14:19
Check that ASCII encoded data in the file can be read into memory.
@jgrewe jgrewe force-pushed the ascii_utf8_strings branch from 97b2198 to 535c07b Compare December 12, 2020 10:29
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #817 (535c07b) into master (c865fd0) will decrease coverage by 0.00%.
The diff coverage is 92.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   95.35%   95.34%   -0.01%     
==========================================
  Files         181      181              
  Lines       13558    13598      +40     
==========================================
+ Hits        12928    12965      +37     
- Misses        630      633       +3     
Impacted Files Coverage Δ
backend/hdf5/h5x/H5DataType.cpp 81.78% <90.62%> (+1.31%) ⬆️
test/hdf5/TestH5.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c865fd0...535c07b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant